Skip to content

Commit 3dcc2ff

Browse files
authored
fix: not skipping the tests stops the copy (Windows ARM) (#1377)
fix: not skipping the tests stops the copy Signed-off-by: Henry Schreiner <[email protected]> Signed-off-by: Henry Schreiner <[email protected]>
1 parent 1c9ec76 commit 3dcc2ff

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

cibuildwheel/windows.py

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -488,20 +488,19 @@ def build(options: Options, tmp_path: Path) -> None:
488488
if repaired_wheel.name in {wheel.name for wheel in built_wheels}:
489489
raise AlreadyBuiltWheelError(repaired_wheel.name)
490490

491-
if build_options.test_command and options.globals.test_selector(config.identifier):
492-
if config.arch == "ARM64" != platform_module.machine():
493-
log.warning(
494-
unwrap(
495-
"""
491+
test_selected = options.globals.test_selector(config.identifier)
492+
if test_selected and config.arch == "ARM64" != platform_module.machine():
493+
log.warning(
494+
unwrap(
495+
"""
496496
While arm64 wheels can be built on other platforms, they cannot
497497
be tested. An arm64 runner is required. To silence this warning,
498498
set `CIBW_TEST_SKIP: *-win_arm64`.
499499
"""
500-
)
501500
)
502-
# skip this test
503-
continue
504-
501+
)
502+
# skip this test
503+
elif test_selected and build_options.test_command:
505504
log.step("Testing wheel...")
506505
# set up a virtual environment to install and test from, to make sure
507506
# there are no dependencies that were pulled in at build time.

0 commit comments

Comments
 (0)