Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Iv core Op in favor of Ive and add rewrite rule for log of it #1092

Open
ricardoV94 opened this issue Nov 15, 2024 · 1 comment
Open

Comments

@ricardoV94
Copy link
Member

Description

Similarly to how we approached Kv/Kve in #1081, we only need one core Op: Ive.

We should include the equivalent log(iv(x)) rewrite for stability, where iv is the expression based on ive returned by the helper.

The goal is to have one canonical form and reduce the number of Ops we need to test/support.

@AdvH039
Copy link

AdvH039 commented Dec 7, 2024

Hey @ricardoV94, for this issue I followed the PR for kv and I expressed iv in the form of a ive helper as iv(v,z) = ive(v,z) * exp(z), but it overflows for iv(v,z) when z>100 for v=4.5 that is around 1e36 which I don't think should be happening.
Please let me know where I'm going wrong. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants