Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added alternative slogdet to return sign and logdet of det op #1041

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Added alternative slogdet to return sign and logdet of det op #1041

wants to merge 11 commits into from
+141 −52

Conversation

tanish1729
Copy link
Contributor

@tanish1729 tanish1729 commented Oct 19, 2024 •
edited by ricardoV94
Loading

Description

Changing slogdet so that we are able to use the rewrites made for Det

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pytensor--1041.org.readthedocs.build/en/1041/

ricardoV94
ricardoV94 reviewed Oct 19, 2024
View reviewed changes
Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need a specialization rewrite that introduces slogdet as a replacement for log(abs(det(x))) and its sign.

I guess we can also do it without the abs.

This should be before we remove useless Blockwise.

pytensor/tensor/rewriting/linalg.py Outdated Show resolved Hide resolved
@tanish1729 tanish1729 mentioned this pull request Oct 19, 2024
Closed
10 tasks
ricardoV94
ricardoV94 reviewed Oct 30, 2024
View reviewed changes
pytensor/tensor/rewriting/linalg.py Outdated Show resolved Hide resolved
pytensor/tensor/rewriting/linalg.py Outdated Show resolved Hide resolved
@tanish1729 tanish1729 marked this pull request as ready for review November 1, 2024 12:26
ricardoV94
ricardoV94 requested changes Nov 11, 2024
View reviewed changes
pytensor/tensor/nlinalg.py Outdated Show resolved Hide resolved
pytensor/tensor/rewriting/linalg.py Outdated Show resolved Hide resolved
pytensor/tensor/rewriting/linalg.py Outdated Show resolved Hide resolved
pytensor/tensor/rewriting/linalg.py Outdated Show resolved Hide resolved
pytensor/tensor/rewriting/linalg.py Outdated Show resolved Hide resolved
tests/tensor/rewriting/test_linalg.py Show resolved Hide resolved
tests/tensor/rewriting/test_linalg.py Outdated Show resolved Hide resolved
tests/tensor/rewriting/test_linalg.py Show resolved Hide resolved
tests/tensor/rewriting/test_linalg.py Show resolved Hide resolved
pytensor/tensor/rewriting/linalg.py Outdated Show resolved Hide resolved
@ricardoV94
Copy link
Member

@tanish1729 changes are shaping up nicely. I think one more round and we're there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardoV94 ricardoV94 ricardoV94 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimizations for Det should also apply to SlogDet
2 participants
@tanish1729 @ricardoV94