-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
files.sync does not remove existing symlinks #1061
Labels
Bug
Label for all kind of bugs.
Comments
I see why this is happening. However, I'm not sure how @Fizzadar wants this operation to handle symlinks. It's an easy fix if Fizzadar wants this operation to handle symlinks. |
Maybe this isn't as straight forward as I first thought. In any case, we still need to know if the |
Yes I think it should. Ideally the sync op should be like rsync’s archive mode I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
As the title describes, using the
files.sync
operation on a remote directory which contains symlinks that are not present in the local version, they are not deleted.To Reproduce
files/update-motd.d/something
(put anything in it, its irrelevant)This will leave the
/etc/update-motd.d
directory as follows:the latter is a symlink. This should be reproducible for any directory which contains such a symlink that is not present locally, though.
Expected behavior
I'm not sure the expected behavior would be to have the symlink be removed, but IMO there should at least be an option for it.
Meta
Running pyinfra v2.9, installed from pip
The text was updated successfully, but these errors were encountered: