Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

from_smiles should allow setting y (label) #9354

Closed
j-adamczyk opened this issue May 23, 2024 · 2 comments
Closed

from_smiles should allow setting y (label) #9354

j-adamczyk opened this issue May 23, 2024 · 2 comments
Labels

Comments

@j-adamczyk
Copy link
Contributor

🚀 The feature, motivation and pitch

Currently from_smiles (https://pytorch-geometric.readthedocs.io/en/latest/modules/utils.html#torch_geometric.utils.from_smiles) does not allow setting y (label). It should take such an argument, and pass it to Data it creates.

Alternatives

No response

Additional context

No response

@rusty1s
Copy link
Member

rusty1s commented May 27, 2024

The current design idea is to add labels afterwards. Does that work in your case?

@j-adamczyk
Copy link
Contributor Author

I was getting a warning about y not being settable from PyCharm, but it went away after updating PyG. Probably due to @property for y being present, but not @y.setter. Anyway, it works, so I'm closing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants