From faeb165d30f5eb0e42b59e420075a10a8605a913 Mon Sep 17 00:00:00 2001
From: gabalafou <gabriel@fouasnon.com>
Date: Wed, 20 Dec 2023 00:36:31 -0700
Subject: [PATCH] underline

---
 .../assets/styles/base/_base.scss                   | 13 +++++++++++++
 .../assets/styles/extensions/_sphinx_design.scss    |  7 +++++++
 .../theme/pydata_sphinx_theme/layout.html           |  2 +-
 3 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/src/pydata_sphinx_theme/assets/styles/base/_base.scss b/src/pydata_sphinx_theme/assets/styles/base/_base.scss
index 5a8f88349..8f4cc1081 100644
--- a/src/pydata_sphinx_theme/assets/styles/base/_base.scss
+++ b/src/pydata_sphinx_theme/assets/styles/base/_base.scss
@@ -179,6 +179,19 @@ pre {
   background-color: var(--pst-color-secondary);
   border: none;
 
+  .fa-arrow-up {
+    // Using margin instead of a space character prevents the space between the
+    // icon and the text from being underlined when the button is hovered.
+    margin-inline-end: 0.5em;
+  }
+
+  @include link-style-hover;
+  &:hover {
+    text-decoration-thickness: 1px;
+    background-color: var(--pst-violet-600);
+    color: var(--pst-color-secondary-text);
+  }
+
   &:focus-visible {
     box-shadow: none;
     outline: $focus-ring-outline;
diff --git a/src/pydata_sphinx_theme/assets/styles/extensions/_sphinx_design.scss b/src/pydata_sphinx_theme/assets/styles/extensions/_sphinx_design.scss
index b5fca887a..39dac5bc9 100644
--- a/src/pydata_sphinx_theme/assets/styles/extensions/_sphinx_design.scss
+++ b/src/pydata_sphinx_theme/assets/styles/extensions/_sphinx_design.scss
@@ -309,6 +309,13 @@ details.sd-dropdown {
 * Buttons (which in Sphinx Design are actually links that look like buttons)
 */
 html {
+  .sd-btn {
+    @include link-style-hover; // override Sphinx Design
+    &:hover {
+      text-decoration-thickness: 1px;
+    }
+  }
+
   @each $name in $sd-semantic-color-names {
     .sd-btn-#{$name} {
       &:focus-visible {
diff --git a/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/layout.html b/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/layout.html
index b83730c48..71d11c19f 100644
--- a/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/layout.html
+++ b/src/pydata_sphinx_theme/theme/pydata_sphinx_theme/layout.html
@@ -61,7 +61,7 @@
   {# the scroll to top button #}
   <button type="button" class="btn rounded-pill" id="pst-back-to-top">
     <i class="fa-solid fa-arrow-up"></i>
-    {{ _("Back to top") }}
+    {{- _("Back to top") -}}
   </button>
 
   {# checkbox to toggle primary sidebar #}