Disallow usage of with_config on a Pydantic model
#9398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #9398 will not alter performanceComparing Summary
|
Viicos
force-pushed
the
disallow-with-config-model
branch
from
26fff66
to
47e7993
Compare
|
Waiting for directions regarding the |
|
Changes look good. Hmm, I can take an in-depth look at the test failure this afternoon... |
|
Will approve once tests pass, but looks great otherwise :) |
Additionally, make `is_pydantic_dataclass` argument pos only, this was missed from a previous PR.
Viicos
force-pushed
the
disallow-with-config-model
branch
from
51c7b60
to
2928dde
Compare
sydney-runkle
approved these changes
May 15, 2024
|
Looks great - please resolve conflicts :). Will merge after that! |
|
Ah, I resolved the conflicts, looked like super minor git problems haha. |
Yep was expected with the other PR merged, thanks for wrapping up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, make
is_pydantic_dataclassargument pos only, this was missed from a previous PR.Fixes #9397