Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pydantic.v1 is broken #9357

Closed
5 of 15 tasks
AngellusMortis opened this issue Apr 30, 2024 · 3 comments
Closed
5 of 15 tasks

pydantic.v1 is broken #9357

AngellusMortis opened this issue Apr 30, 2024 · 3 comments
Labels
bug V1 Bug related to Pydantic V1.X pending Awaiting a response / confirmation

Comments

@AngellusMortis
Copy link

Initial Checks

  • I have searched GitHub for a duplicate issue and I'm sure this is something new
  • I have searched Google & StackOverflow for a solution and couldn't find anything
  • I have read and followed the docs and still think this is a bug
  • I am confident that the issue is with pydantic (not my code, or another library in the ecosystem like FastAPI or mypy)

Description

The issue #6694 was not resolved or completed correctly.

The below code sample works in v2, but not v1.10.15.

Example Code

from pydantic.v1.color import Color
from pydantic.v1.fields import ModelField

Python, Pydantic & OS Version

pydantic v1.10.15

Affected Components

@AngellusMortis AngellusMortis added bug V1 Bug related to Pydantic V1.X pending Awaiting a response / confirmation labels Apr 30, 2024
@sydney-runkle
Copy link
Member

@AngellusMortis,

Indeed, looks like things weren't fully implemented there. PR welcome with a fix! This is relatively low priority though, given that it's on the V1 end of things.

@sydney-runkle
Copy link
Member

I believe this may be fixed by #9162

@sydney-runkle
Copy link
Member

^^ closed by #9162, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug V1 Bug related to Pydantic V1.X pending Awaiting a response / confirmation
Projects
None yet
Development

No branches or pull requests

2 participants