Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark Mode #39

Open
samuelcolvin opened this issue Dec 1, 2023 · 3 comments · May be fixed by #113
Open

Dark Mode #39

samuelcolvin opened this issue Dec 1, 2023 · 3 comments · May be fixed by #113
Labels
enhancement New feature or request
Milestone
v0.7.0

Comments

@samuelcolvin
Copy link
Member

I know, I know, but still - it is nice to have.

Shouldn't be too hard to implement - the default implementations just need to change color and background-color, and bootstrap already has support for dark mode via css variables.
@samuelcolvin samuelcolvin added the enhancement New feature or request label Dec 1, 2023
@justindhillon
Copy link
Contributor

I think this is a great idea! You can assign this to me, I will start working on this today.

@samuelcolvin
Copy link
Member Author

@justindhillon great, please create a PR and link to here.

@justindhillon
Copy link
Contributor

I'm gracefully bowing out of this challenge, relinquishing it to the next courageous soul willing to take it on.

@ischaojie ischaojie linked a pull request Dec 21, 2023 that will close this issue
Draft
@samuelcolvin samuelcolvin mentioned this issue Dec 22, 2023
Closed
@sydney-runkle sydney-runkle added this to the v2.6.0 milestone Apr 19, 2024
@sydney-runkle sydney-runkle modified the milestones: v0.6.0, v0.7.0 May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging a pull request may close this issue.

Support dark mode ischaojie/FastUI
3 participants
@samuelcolvin @sydney-runkle @justindhillon