Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run inside Jupyter #92

Open
juliotux opened this issue Dec 18, 2022 · 1 comment
Open

Run inside Jupyter #92

juliotux opened this issue Dec 18, 2022 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@juliotux
Copy link

With the recent changes, subprocess-tee is using asyncio.run. However, this call tries to create a new loop, raising an exception:

RuntimeError: asyncio.run() cannot be called from a running event loop

To reproduce, just create a Jupyter notebook with this cell and run:

import subprocess_tee
subprocess_tee.run('sleep 1')

More details at jupyter blog or stackoverflow.

@ssbarnea
Copy link
Member

ssbarnea commented Jan 2, 2023

@juliotux You are welcomed to raise a PR and also to include a test for it. Jypyter use was never in-scope of the library and unless someone contributes the code for it it will remain unsorted.

@ssbarnea ssbarnea added bug Something isn't working help wanted Extra attention is needed labels Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants