Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up enforced forwarding to https if not running locally #46

Open
AetherUnbound opened this issue Jan 3, 2023 · 2 comments · Fixed by #51
Open

Set up enforced forwarding to https if not running locally #46

AetherUnbound opened this issue Jan 3, 2023 · 2 comments · Fixed by #51

Comments

@AetherUnbound
Copy link
Contributor

It would appear that Heroku doesn't automatically forward HTTP requests to HTTPS, and since we aren't handling the load balancing on the Heroku end we'll need to do this from Django.

There are a few guides for doing exactly this:

We'll want to set this up to be disabled locally since that's fine to be over HTTP (and would be difficult to set up HTTPS locally).

@AetherUnbound
Copy link
Contributor Author

The fix in #51 broke deployments, unfortunately. We'll have to look into how this change affects the baking we do for Netlify.

@AetherUnbound
Copy link
Contributor Author

Note: This also broke the Netlify build deployment callbacks since it was using http. If we are able to address this, we'll need to update that link too (and verify it works).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant