Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for private repositories #1

Open
nSimonFR opened this issue Oct 2, 2018 · 2 comments
Open

Support for private repositories #1

nSimonFR opened this issue Oct 2, 2018 · 2 comments

Comments

@nSimonFR
Copy link

nSimonFR commented Oct 2, 2018

I'd love to get your fancy notifications when private repos push new releases !

@pyatyispyatil pyatyispyatil self-assigned this Oct 3, 2018
@doniyor2109
Copy link

Hi @pyatyispyatil. I wanted to work on this if you do not mind.

I see that this bot works with one static GitHub token. As private repos are individual for each user, we should take GitHub token from user as well. But with current implementation I am not sure if it is possible.

So I wanted to move repo data inside users in this case it will be individual for each of them. The disadvantage is that it same repos will be fetch multiple times.

What do you think about it?

@pyatyispyatil
Copy link
Owner

@doniyor2109 I think it would be preferable to add the ability to add a separate token through the bot UI in Telegram using a separate button. Well, also add an alert when adding a new repository, if it is suddenly private and the user does not have an individual token.

IMHO, the main use of the bot should be with the main github token so that users don't think too much about it.

For the rest, I'm glad you decided to take on this task.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants