Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable gamma correction with PyGFX canvas #78

Open
gselzer opened this issue Jan 4, 2025 · 1 comment
Open

Enable gamma correction with PyGFX canvas #78

gselzer opened this issue Jan 4, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@gselzer
Copy link
Collaborator

gselzer commented Jan 4, 2025

PyGFX provides a shader-side gamma within the [renderer](https://github.com/pygfx/pygfx/blob/b865a48ae6268bd1a7c4e6e87eb23d25be2c2d61/pygfx/renderers/wgpu/engine/renderer.py#L110, but ideally we'd be able to apply gamma separately to each dataset being displayed (i.e. to each Image object). Unless I missed something, I don't think this is currently possible.

Naturally, we can also do it on the CPU, as @tlambert03 suggested in #76, but ideally it'd be on the GPU.

@almarklein do you have any insight here?

@gselzer gselzer added the enhancement New feature or request label Jan 4, 2025
@gselzer gselzer mentioned this issue Jan 4, 2025
7 tasks
@almarklein
Copy link

This is currently not possible, but adding gamma prop to the gfx.ImageBasicMaterial and VolumeBasicMaterial seems reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants