build: add back support for python3.8 (#19)

* build: add back py38

* future

Author: tlambert03

.github/workflows/ci.yml

@@ -33,7 +33,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest, macos-latest]
-        python-version: ["3.10", "3.11"]
+        python-version: ["3.8", "3.10", "3.11"]
 
   test-array-libs:
     uses: pyapp-kit/workflows/.github/workflows/test-pyrepo.yml@v2

pyproject.toml

@@ -19,13 +19,14 @@ name = "ndv"
 dynamic = ["version"]
 description = "simple nd image viewer"
 readme = "README.md"
-requires-python = ">=3.9"
+requires-python = ">=3.8"
 license = { text = "BSD-3-Clause" }
 authors = [{ name = "Talley Lambert", email = "[email protected]" }]
 classifiers = [
     "Development Status :: 3 - Alpha",
     "License :: OSI Approved :: BSD License",
     "Programming Language :: Python :: 3",
+    "Programming Language :: Python :: 3.8",
     "Programming Language :: Python :: 3.9",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",
@@ -68,7 +69,7 @@ repository = "https://github.com/pyapp-kit/ndv"
 # https://docs.astral.sh/ruff
 [tool.ruff]
 line-length = 88
-target-version = "py39"
+target-version = "py38"
 src = ["src"]
 
 # https://docs.astral.sh/ruff/rules

src/ndv/data.py

@@ -1,5 +1,7 @@
 """Sample data for testing and examples."""
 
+from __future__ import annotations
+
 import numpy as np
 
 __all__ = ["nd_sine_wave", "cells3d"]

src/ndv/viewer/_data_wrapper.py

@@ -5,10 +5,20 @@
 import logging
 import sys
 from abc import abstractmethod
-from collections.abc import Container, Hashable, Iterable, Iterator, Mapping, Sequence
 from concurrent.futures import Future, ThreadPoolExecutor
 from contextlib import suppress
-from typing import TYPE_CHECKING, ClassVar, Generic, TypeVar
+from typing import (
+    TYPE_CHECKING,
+    ClassVar,
+    Container,
+    Generic,
+    Hashable,
+    Iterable,
+    Iterator,
+    Mapping,
+    Sequence,
+    TypeVar,
+)
 
 import numpy as np
 

src/ndv/viewer/_dims_slider.py

@@ -24,8 +24,7 @@
 from superqt.utils import signals_blocked
 
 if TYPE_CHECKING:
-    from collections.abc import Hashable, Mapping
-    from typing import TypeAlias
+    from typing import Hashable, Mapping, TypeAlias
 
     from qtpy.QtGui import QResizeEvent
 

src/ndv/viewer/_lut_control.py

@@ -12,7 +12,7 @@
 from ._dims_slider import SS
 
 if TYPE_CHECKING:
-    from collections.abc import Iterable
+    from typing import Iterable
 
     import cmap
 

src/ndv/viewer/_viewer.py

@@ -23,9 +23,8 @@
 from ._lut_control import LutControl
 
 if TYPE_CHECKING:
-    from collections.abc import Hashable, Iterable, Sequence
     from concurrent.futures import Future
-    from typing import Any, Callable, TypeAlias
+    from typing import Any, Callable, Hashable, Iterable, Sequence, TypeAlias
 
     from qtpy.QtGui import QCloseEvent
 

tests/conftest.py

@@ -1,6 +1,5 @@
 import gc
-from collections.abc import Iterator
-from typing import TYPE_CHECKING
+from typing import TYPE_CHECKING, Iterator
 
 import pytest