Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support model dependent rule presets #2271

Open
MattHag opened this issue Feb 11, 2024 · 11 comments
Open

Support model dependent rule presets #2271

MattHag opened this issue Feb 11, 2024 · 11 comments

Comments

@MattHag
Copy link
Contributor

MattHag commented Feb 11, 2024

Information

  • Solaar version (solaar --version and git describe --tags): 1.1.10

Is your feature request related to a problem? Please describe.
The rule editor is not as straightforward as Logi Options+ to set up rules for button presses and gestures. Updates can improve that, but presets support. And presets for at least common models, such as the MX Master series would quickly help to get a basic configuration to play around with in the rule editor.

Describe the solution you'd like
Add presets support, which means

  • Add some rules.yaml
  • Somehow tie them to compatible mice e.g. MX Master, Master 2S, MX Master 3, MX Master 3S
  • Ask to load presets, when a compatible device is connected the first time
    • Also support a way to switch them later. Somewhere related to the Rule editor button.

As an alternative or addition, It would also be possible to provide patterns, e.g.

  • I want to use the thumb wheel to switch tabs, provide me the correct trigger setup, so I only need to add the action to trigger.
  • I want to use the gestures, provide me the rules for the Gesture button and gestures in the 4 directions, so I only need to add the action to execute.

Describe alternatives you've considered
Providing YAML files for download is also possible, but still cumbersome and not as simple as it should be.

Additional context
This doesn't avoid improvements to the rule editor, but should ensure that user do not drop Solaar due to the steep learning curve in setting up rules and grasping what the need for this and that functionality is.

@MattHag MattHag changed the title Support rule presets and reduce learning curve for rule setup. Support rule presets and reduce learning curve for rule setup Feb 13, 2024
@El-Barto89
Copy link

El-Barto89 commented Mar 1, 2024

It would be amazing. I've really hard times understanding how it works. I came from AHK. Just a few examples would be perfect...

@MattHag
Copy link
Contributor Author

MattHag commented Mar 9, 2024

This ticket is one, that aims towards reducing the need for help requests like in #2326, which in the current state of Solaar 1.1.11 is totally understandable. The long term solution needs to be a device configuration, that does not require a manual to map key action etc. Everything that can automatically happen in the background needs to happen automatically.

@pfps
Copy link
Collaborator

pfps commented Mar 27, 2024

What presets do you think would be universally helpful? I'm having trouble coming up with any.

@MattHag
Copy link
Contributor Author

MattHag commented Mar 27, 2024

Take the default configuration on macOS or Windows and it's a good start. On MX Master

  • Gesture button -> Super_L
  • Left/Right Gesture -> Switch desktop

But I'd prefer a more general approach to this, with just simplifying the interface, so it's user-friendly and doesn't have a steep learning curve.

@pfps
Copy link
Collaborator

pfps commented Mar 27, 2024

Much of this is done in Linux by parts of the windowing system. Solaar should not be in this business.

@MattHag
Copy link
Contributor Author

MattHag commented Mar 27, 2024

That all maps to keyboards shortcuts, I am not sure if they differ. However, the current approach just takes too many clicks to set up some basic key mappings. Thus, the simplification of the rule editor should take a higher priority and then the need and feasibility of further improvements can be discussed.

@pfps
Copy link
Collaborator

pfps commented Mar 28, 2024

Presets are only helpful if they are commonly used. What are some good examples?

@MattHag
Copy link
Contributor Author

MattHag commented Mar 28, 2024

Desktop switching on the left/right gestures

@pfps
Copy link
Collaborator

pfps commented Mar 28, 2024

I certainly don't want that. And that's not tied to a particular device.

@MattHag
Copy link
Contributor Author

MattHag commented Mar 28, 2024

Sure tied to a device otherwiese it makes no sense. But that's already implemented. You'll never find a config that's suitable, but the Logiops defaults are not bad and showcasing the same preconfigured options, which are easy to adopt is not bad. However the implementation needs to be well thought with good maintenence and testability in mind.

The UI should change to a per device like the main window anyways and special rules not appliccable can be in a General rules entry.

@pfps
Copy link
Collaborator

pfps commented Mar 28, 2024

No, these rules work for any mouse that supports XY processing, not a particular mouse. If I have multiple mice that support XY processing, I generally wouldn't want to have different rules for their mouse gestures. Similarly, if I have multiple keyboards with a particular divertable key I wouldn't generally want to have different processing for this key on my different keyboards. So I prefer having a global view of my rules.

@MattHag MattHag changed the title Support rule presets and reduce learning curve for rule setup Reduce learning curve for rule setup Apr 15, 2024
@MattHag MattHag changed the title Reduce learning curve for rule setup Support model dependent rule presets Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants