Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly test commit messages on branch push #643

Open
evrardjp opened this issue Mar 3, 2021 · 1 comment · May be fixed by #646
Open

Properly test commit messages on branch push #643

evrardjp opened this issue Mar 3, 2021 · 1 comment · May be fixed by #646

Comments

@evrardjp
Copy link
Contributor

evrardjp commented Mar 3, 2021

Description:

We should test commit messages on PRs but also on branches pushes. Here it's not doing it right.
@purpleidea
Copy link
Owner

I approve =D

evrardjp added a commit to evrardjp/mgmt that referenced this issue Mar 3, 2021
@evrardjp
test: Add guard when no commit needs testing
1873e02 
Without this patch, github actions fail.

It's a temporary workaround until [1] is done.

[1]: purpleidea#643
This was referenced Mar 3, 2021
Merged
Open
LuausDalmolin added a commit to LuausDalmolin/mgmt that referenced this issue Aug 24, 2022
@LuausDalmolin @evrardjp
test: Add guard when no commit needs testing
e5a53b9 
Without this patch, github actions fail.

It's a temporary workaround until [1] is done.

[1]: purpleidea/mgmt#643
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Fix commit testing evrardjp/mgmt
2 participants
@purpleidea @evrardjp