Linting does not use .puppet-lint.rc

[glennsarti]

Cross ref: puppetlabs/puppet-vscode#304

Original author: @setaou

---

What Versions are you running?

OS Version: Ubuntu 18.04
VSCode Version: 1.24.1
Puppet Extension Version: 0.10.0
Puppet Agent Version: 4.10.4

What You Are Seeing?

I have a .puppet-lint.rc file at the root of my workspace containing only the following line :
--no-140chars-check

If I use the puppet-lint command from a terminal, it uses this config file and ignores the warnings about long lines. However, the linting in vscode still shows the warnings.

What is Expected?

The linting in vscode should enforce the options set in .puppet-lint.rc.

[glennsarti]

Added commentary

---

@glennsarti : Is this inside a module or control repository?
@setaou : It is at the root of the repository (which is the whole /etc/puppet).

[glennsarti]

Hrmm ok...so it's neither a module or control repo.

So it looks like our change directory command isn't working anymore and we'll need to emulate - https://github.com/rodjek/puppet-lint/blob/41eec3b1d221ee0919af1b5e17adbf898fbb4432/lib/puppet-lint/optparser.rb#L139-L146

Probably a good idea to change this anyway as https://github.com/lingua-pupuli/puppet-editor-services/blob/master/lib/puppet-languageserver/manifest/validation_provider.rb#L41 isn't threadsafe