Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github/workflows/provider-prerequisites.yaml's Comment on PR with Details of Schema Check breaks fork based PRs #113

Open
denopink opened this issue Oct 16, 2023 · 1 comment
Assignees

Comments

@denopink
Copy link

Looks like the sub-job Comment on PR with Details of Schema Check requires the workflow's github.token to have read and write permissions.

This becomes an issue when a pr is created from a fork, since the token is from the fork and not from the parent repo.

Can we remove this section?

- if: github.event_name == 'pull_request'
name: Comment on PR with Details of Schema Check
uses: thollander/actions-comment-pull-request@v2
with:
GITHUB_TOKEN: ${{ github.token }}
message: |
### Does the PR have any schema changes?
${{ env.SCHEMA_CHANGES }}

cc: @schmidtw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants