Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change plugin download and installation to use engine events for progress #15821

Open
PollRobots opened this issue Mar 28, 2024 · 0 comments 路 May be fixed by #16094
Open

Change plugin download and installation to use engine events for progress #15821

PollRobots opened this issue Mar 28, 2024 · 0 comments 路 May be fixed by #16094
Labels
area/cli UX of using the CLI (args, output, logs) kind/enhancement Improvements or new features kind/postmortem-followup Followup item from postmortem

Comments

@PollRobots
Copy link
Contributor

Hello!

  • Vote on this issue by adding a 馃憤 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Currently the plugin download mechanism reports progress using stdout, this causes a variety of odd behavior and doesn't work well with the ProgressDisplay used for showing other progress.

This was a factor in #15668 and is causal for #14250

Affected area/feature

CLI

@PollRobots PollRobots added area/cli UX of using the CLI (args, output, logs) kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Mar 28, 2024
@tgummerer tgummerer added the kind/postmortem-followup Followup item from postmortem label Mar 28, 2024
@justinvp justinvp removed the needs-triage Needs attention from the triage team label Mar 28, 2024
@PollRobots PollRobots linked a pull request Apr 30, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli UX of using the CLI (args, output, logs) kind/enhancement Improvements or new features kind/postmortem-followup Followup item from postmortem
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants