Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass PlanResourceChange through downstream tests #1962

Open
VenelinMartinov opened this issue May 13, 2024 · 3 comments
Open

Pass PlanResourceChange through downstream tests #1962

VenelinMartinov opened this issue May 13, 2024 · 3 comments
Assignees
Labels
kind/engineering Work that is not visible to an external user

Comments

@VenelinMartinov
Copy link
Contributor

VenelinMartinov commented May 13, 2024

What happened?

@t0yv0 recently suggested running PlanResourceChange through downstream tests as a short-term way to gain more confidence in it.

This should help with #1785

We already know about some issues (GCP bucket) but it might be useful to learn about other problematic resources

Example

.

Output of pulumi about

.

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@VenelinMartinov VenelinMartinov added the kind/engineering Work that is not visible to an external user label May 13, 2024
@VenelinMartinov VenelinMartinov self-assigned this May 13, 2024
@t0yv0
Copy link
Member

t0yv0 commented May 13, 2024

This would be much appreciated since any bugs discovered here also probably affect AWS users through a handful of enrolled resources, and would also be happy-path simple bugs, not corner-case bugs discovered by randomized testing.

@VenelinMartinov
Copy link
Contributor Author

I ran a round of downstream tests but we'd get more valuable results after #1849, so I'll finish that up first.

@VenelinMartinov
Copy link
Contributor Author

Ok, biggest ones from the first run:

A bunch of panics: #1964 and #1966 maybe all root caused by #1916 and #1915

2 tfgen issues: #1965

A bunch of unexpected updates: #1967

@VenelinMartinov VenelinMartinov changed the title Run PlanResourceChange through downstream tests Pass PlanResourceChange through downstream tests May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/engineering Work that is not visible to an external user
Projects
None yet
Development

No branches or pull requests

2 participants