-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconsider TF plugin SDK fork #1956
Labels
kind/enhancement
Improvements or new features
Comments
In my latest understanding 74776a5 exposing provider internals is actually a little unfortunate, primary motivation was to integrate with as-is detailedDiff computation but with #1895 we should be able to write that correctly now and remove the need for 74776a5. |
pulumi/terraform-plugin-sdk@53f910a has been removed, since it was causing bugs in the bridge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello!
Issue details
After discussing with @t0yv0, he suggested we might no longer need the plugin sdk fork. Looking at the diff the following changes look eventful:
pulumi/terraform-plugin-sdk@53f910a -> this one is the most interesting, related to 64 bit int support and timeouts. Perhaps no longer needed? We should carefully test ths.
pulumi/terraform-plugin-sdk@e2a20ae -> this is an optional optimisation, perhaps we can work that into the providers which need it/ into the bridge with some golink magic?
pulumi/terraform-plugin-sdk@74776a5
The rest of the changes are mostly related to exposing internal functions, which we could put into a separate library.
Affected area/feature
The text was updated successfully, but these errors were encountered: