Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fields with default values should not be required #98

Open
iwahbe opened this issue Jul 12, 2023 · 0 comments
Open

Fields with default values should not be required #98

iwahbe opened this issue Jul 12, 2023 · 0 comments
Labels
kind/bug Some behavior is incorrect or out of spec

Comments

@iwahbe
Copy link
Member

iwahbe commented Jul 12, 2023

What happened?

Fields where Annotator.SetDefault is in effect but not marked as pulumi:...,optional are still treated as required in the schema.

Expected Behavior

They should be optional in the schema. Fields with non-nil default values will always be provided. Fields not annotated as optional but with provided ENV values should be marked as optional in the schema and error at runtime if no value is provided.

Steps to reproduce

Remove the resources.provider.properties.password in credentials/consumer/Pulumi.yaml. Then run FOO=password pulumi up.

Output of pulumi about

NA

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@iwahbe iwahbe added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Jul 12, 2023
@iwahbe iwahbe removed the needs-triage Needs attention from the triage team label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Development

No branches or pull requests

1 participant