-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically unmarshal complex configuration types #171
Labels
kind/enhancement
Improvements or new features
Comments
blampe
added
kind/enhancement
Improvements or new features
needs-triage
Needs attention from the triage team
labels
Dec 20, 2023
blampe
changed the title
Automatically unmarshal complex types
Automatically unmarshal complex configuration types
Dec 20, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Non-primitive config fields are automatically
JSON.Stringify
-d when sent to the server:https://github.com/pulumi/pulumi/blob/f500bef2fa732aab23c644dc07ed9b101a9cfaaf/pkg/codegen/nodejs/gen.go#L794-L797
However we aren't unmarshaling them on the receiving end. A type like this results in an error:
The bridge seems to handle this here:
https://github.com/pulumi/pulumi-terraform-bridge/blob/0f7ccfdef31d3fddd4eb46c9770d460bbfbe81e3/pkg/tfbridge/config_encoding.go#L150C11-L174
I think this is essentially the issue:
pulumi-go-provider/provider.go
Lines 710 to 711 in 2b02372
We unmarshal the provider's config the same way we unmarshal properties, but this JSON behavior is unique to config.
The text was updated successfully, but these errors were encountered: