Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency solving misses packages when copying two RPMs with the same name but different versions #3728

Open
ianballou opened this issue Sep 16, 2024 · 2 comments
Labels

Comments

@ianballou
Copy link
Contributor

Version

    {
      "name": "[email protected]",
      "last_heartbeat": "2024-09-16T18:08:27.107714Z",
      "versions": {
        "deb": "3.3.1",
        "rpm": "3.27.1",
        "core": "3.58.0",
        "file": "3.58.0",
        "ostree": "2.4.3",
        "python": "3.12.2",
        "ansible": "0.22.1",
        "certguard": "3.58.0",
        "container": "2.21.0"
      }

Describe the bug
When copying walrus 5.21 and walrus 0.71 from https://jlsherrill.fedorapeople.org/fake-repos/needed-errata/ into an empty repository with dependency solving enabled, the dependencies of walrus 0.71 do not get copied as well. However, if only copying walrus 0.71, the dependencies do get copied.

To Reproduce
Sync https://jlsherrill.fedorapeople.org/fake-repos/needed-errata
Copy walrus 0.71 and 5.21 into an empty repo with dependency solving

Expected behavior
'whale' and other deps get copied.

Additional context
Tested via Katello on non-standard Pulp versions.

@ggainey
Copy link
Contributor

ggainey commented Jan 25, 2025

If you turn on SOLVER_DEBUG_LOGS and then do a dep-solving advanced copy of that repo for both 0.71 and 5.21, you will find the following in the logs:

cannot install both walrus-0:5.21-1.noarch and walrus-0:0.71-1.noarch

It's possible we could consider this a "dependency warning" that should be reflected back in the task-output - currently, it isn't in the list found in _build_warnings()

The question is - has using dep-solving ever found the dependencies of an RPM when multiple versions of that RPM are being copied at the same time?

@dralley
Copy link
Contributor

dralley commented Feb 10, 2025

The question is - has using dep-solving ever found the dependencies of an RPM when multiple versions of that RPM are being copied at the same time?

It should have, but did it? I don't know. We do have dep solving tests but they are a bit sparse and most assume an empty repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants