-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect package location in metadata when relative path contains a /
#3719
Comments
Fix pulp/pulp_rpm#3719 Instead of uploading RPM packages as artifacts in one API call, and then creating a content from them in a separate call, we will now create the content directly. There are mutiple reasons to do so: - One API call instead of two - It fixes the issue with installing packages mentioned above - @dkliban says there is an effort to not allow uploading artifacts on shared Pulp instances There is only one disadvantage of doing this, we lose track of what RPM packages belong to a specific Copr build ID. We will use labels for this, once they are implemented. See pulp/pulpcore#3338 (comment)
Fix pulp/pulp_rpm#3719 Instead of uploading RPM packages as artifacts in one API call, and then creating a content from them in a separate call, we will now create the content directly. There are mutiple reasons to do so: - One API call instead of two - It fixes the issue with installing packages mentioned above - @dkliban says there is an effort to not allow uploading artifacts on shared Pulp instances There is only one disadvantage of doing this, we lose track of what RPM packages belong to a specific Copr build ID. We will use labels for this, once they are implemented. See pulp/pulpcore#3338 (comment)
Is there a practical issue here or is it mostly inconsequential? location_href is something that really should never have been added to our schema at all, it was a mistake. Preferably we would remove it entirely. So my inclination is not to change anything until we can do that. |
@dkliban proposed I shouldn't upload RPM packages as artifacts and create content out of them but rather do this in one step. And also to not specify the relative path. Everything works as expected now, so solving or not solving this issue won't affect me. |
Version
pulpcore 3.56.1
pulp_rpm 3.27.1
Describe the bug
When I create a package in a repository from an artifact using the following commands, the package is published to the correct location, however, the metadata does not match that location.
Package location:
http://localhost:5001/pulp/content/default/myrepo/Packages/f/frostyx/test-pulp-1/camel-0.1-1.noarch.rpm
Metadata in primary.xml:
Note that location is
"Packages/c/camel-0.1-1.noarch.rpm"
The text was updated successfully, but these errors were encountered: