Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VLEN should not be set by preprocessor macro in ara_pkg.sv #293

Closed
jerryz123 opened this issue Mar 19, 2024 · 2 comments
Closed

VLEN should not be set by preprocessor macro in ara_pkg.sv #293

jerryz123 opened this issue Mar 19, 2024 · 2 comments

Comments

@jerryz123
Copy link

This makes integration in other projects cumbersome. VLEN should follow same pattern as NR_LANES... ara_tb should set the VLEN parameter from the macro, but ara_pkg should not reference the macro.

@mp-17
Copy link
Collaborator

mp-17 commented Jun 14, 2024

Hello @jerryz123, you are right. We have done it in the beginning to speed up the development but now it's really ugly.
We are moving to a more realistic SoC now, and I have already made VLEN a verilog parameter to solve this.

@mp-17
Copy link
Collaborator

mp-17 commented Jul 2, 2024

Solving in #317

@mp-17 mp-17 closed this as completed Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants