Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests in random order #705

Open
1 of 5 tasks
bess opened this issue Oct 23, 2024 · 0 comments · May be fixed by #710
Open
1 of 5 tasks

Run tests in random order #705

bess opened this issue Oct 23, 2024 · 0 comments · May be fixed by #710
Assignees
@jrgriffiniii @20LM22
Labels
learning-friendly technical-debt

Comments

@bess
Copy link
Contributor

bess commented Oct 23, 2024

What maintenance needs to be done?

We should be using the rspec setting config.order = :random

Level of urgency

  • High
  • Moderate
  • Low

Why is this maintenance needed?

Running tests in random order is a best practice we should be following. It ensures that there are no order-dependent tests in our suite. Currently, we must have some order-dependent tests because if I try to turn on the random option in rspec several tests fail.

Acceptance criteria

  • Uncomment config.order = :random in the spec/spec_helper.rb file
  • Ensure all tests pass when run in random order
@20LM22 20LM22 linked a pull request Nov 4, 2024 that will close this issue
Draft
@jrgriffiniii jrgriffiniii self-assigned this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrgriffiniii jrgriffiniii

@20LM22 20LM22

Labels
learning-friendly technical-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Runs tests in random order pulibrary/pdc_discovery
3 participants
@bess @jrgriffiniii @20LM22