Skip to content

Move away from system.scss #426

@sandbergja

Description

@sandbergja

What maintenance needs to be done?

system.scss should be split into individual scss files. Components that currently require system.scss should instead only use the smaller pieces that they actually need.

Level of urgency

  • High
  • Moderate
  • Low

Why is this maintenance needed?

There is a lot of duplication between system.scss and other files. We only included system.scss in components as a matter of expediency while migrating Lux -- it is better to only import the scss bits that we actually need.

Acceptance criteria

  • system.scss is split into smaller files, each with a clear focus
  • components that previously imported system.scss import the smaller scss files that they need.
  • style.scss still has everything that is needed
  • We remove system.scss

Notes

I originally thought that importing system.scss when we don't need it increased bundle sizes. However, it looks like the build process is smart enough not to include scss that we don't use in the bundled components and css.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions