Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework constructor of PSEvent #28

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Rework constructor of PSEvent #28

wants to merge 2 commits into from

Conversation

marksteward
Copy link
Contributor

Rework constructor of PSEvent so that it always take a date, and the override attribute is accurate. This allows us to compare two PSEvents for equality and use .override in templates.

Fixes #8, #15 and #22

Rework constructor of PSEvents so that it always take a date, and
the override attribute is accurate. This allows us to compare two
PSEvents for equality and use .override in templates.

Fixes #8, #15 and #22
@Jonty
Copy link
Member

Jonty commented Jan 31, 2025

Oh wow there's a 9 year old PR just sat here. Want to resolve the conflicts and get it merged?

We could aim to merge it on its 10th birthday, at a PS. With cake and candles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make date/datetime types consistent
2 participants