Skip to content

Commit a17cc00

Browse files
PubNub SDK v5.0.1 release.
1 parent ac5bcef commit a17cc00

File tree

7 files changed

+23
-8
lines changed

7 files changed

+23
-8
lines changed

.github/CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
* @crimsonred @mohitpubnub @budgetpreneur
22
.travis/* @parfeon @crimsonred @budgetpreneur
3-
README.md @polarweasel @samiahmedsiddiqui @techwritermat
3+
README.md @techwritermat

.pubnub.yml

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,16 @@
11
---
2-
version: v5.0.0
2+
version: v5.0.1
33
changelog:
4+
-
5+
changes:
6+
-
7+
text: "Fixed missing UUID in message action events."
8+
type: bug
9+
-
10+
text: "Fixed custom count settings in Fetch Messages with Message Actions."
11+
type: bug
12+
date: 2021-07-06
13+
version: v5.0.1
414
-
515
changes:
616
-

PubNubUnity/Assets/PubNub/Builders/History/FetchMessagesRequestBuilder.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ public FetchMessagesRequestBuilder(PubNubUnity pn):base(pn, PNOperationType.PNFe
1616
private long EndTime = -1;
1717

1818
private const ushort MaxCount = 100;
19+
private const ushort MaxCountWithActions = 25;
1920
private ushort count = MaxCount;
2021
private ushort HistoryCount {
2122
get {
@@ -118,8 +119,8 @@ protected override void RunWebRequest(QueueManager qm){
118119
this.PubNubInstance.PNLog.WriteToLog(string.Format ("FetchMessagesRequestBuilder: \nChannel {0} \nStartTime: {1} \nthis.EndTime:{2} \nthis.HistoryCount:{3} \nthis.ReverseHistory:{4}", string.Join(",", this.ChannelsToUse.ToArray()), this.StartTime, this.EndTime, this.HistoryCount, this.ReverseHistory), PNLoggingMethod.LevelInfo);
119120
#endif
120121

121-
if(IncludeMessageActionsInHistory || ChannelsToUse.Count > 1){
122-
this.HistoryCount = 25;
122+
if (((this.HistoryCount<=0) || (this.HistoryCount>MaxCountWithActions)) && (IncludeMessageActionsInHistory || ChannelsToUse.Count > 1)){
123+
this.HistoryCount = MaxCountWithActions;
123124
}
124125

125126
Uri request = BuildRequests.BuildFetchRequest(

PubNubUnity/Assets/PubNub/PlayModeTests/PlayModeTests.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1512,7 +1512,7 @@ public IEnumerator TestSignalsAndSubscribe()
15121512

15131513
}
15141514

1515-
[UnityTest]
1515+
[UnityTest, Timeout(60000)]
15161516
public IEnumerator TestMessageActions()
15171517
{
15181518
PNConfiguration pnConfiguration = PlayModeCommon.SetPNConfig(false);
@@ -1548,7 +1548,8 @@ public IEnumerator TestMessageActions()
15481548
Debug.Log(mea.MessageActionsEventResult.Data.ActionType);
15491549
Debug.Log(mea.MessageActionsEventResult.Data.ActionValue);
15501550
Debug.Log(mea.MessageActionsEventResult.Data.MessageTimetoken);
1551-
Debug.Log(mea.MessageActionsEventResult.Data.UUID);
1551+
Debug.Log("UUID in Event" + mea.MessageActionsEventResult.Data.UUID);
1552+
Assert.True(mea.MessageActionsEventResult.Data.UUID.Equals(pnConfiguration2.UUID));
15521553
}
15531554
Debug.Log(mea.MessageActionsEventResult.MessageActionsEvent);
15541555
Debug.Log(mea.MessageActionsEventResult.Subscription);

PubNubUnity/Assets/PubNub/PubNubUnity/PubNubUnityBase.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ namespace PubNubAPI
77
public class PubNubUnityBase
88
{
99
protected Counter publishMessageCounter;
10-
private const string build = "5.0.0";
10+
private const string build = "5.0.1";
1111
private string pnsdkVersion = string.Format ("PubNub-CSharp-Unity/{0}", build);
1212

1313
public string Version {

PubNubUnity/Assets/PubNub/Workers/SubscriptionWorker.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -900,6 +900,9 @@ internal void CreateMessageActionsEventResult(SubscribeMessage subscribeMessage,
900900
pnMessageActionsEventResult = new PNMessageActionsEventResult();
901901
pnMessageActionsEventResult.MessageActionsEvent = MessageActionsHelpers.GetPNMessageActionsEventFromString(messageActionsEvent);
902902
pnMessageActionsEventResult.Data = MessageActionsHelpers.ExtractMessageAction(data);
903+
if(pnMessageActionsEventResult.Data != null){
904+
pnMessageActionsEventResult.Data.UUID = subscribeMessage.IssuingClientId;
905+
}
903906
pnMessageActionsEventResult.Channel = subscribeMessage.Channel.Replace(Utility.PresenceChannelSuffix, "");
904907
pnMessageActionsEventResult.Subscription = subscribeMessage.SubscriptionMatch.Replace(Utility.PresenceChannelSuffix, "");
905908

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
5.0.0
1+
5.0.1

0 commit comments

Comments
 (0)