update stack lock (#21)

Author: kooksee

generic/util.go

@@ -191,7 +191,12 @@ func IsNil(err interface{}) bool {
 		return true
 	}
 
-	return v.IsZero()
+	switch v.Kind() {
+	case reflect.Chan, reflect.Func, reflect.Map, reflect.Pointer, reflect.UnsafePointer, reflect.Slice, reflect.Interface:
+		return v.IsNil()
+	default:
+		return false
+	}
 }
 
 func Init(fn func()) error {

generic/util_test.go

@@ -3,11 +3,28 @@ package generic
 import (
 	"strconv"
 	"testing"
+
+	"github.com/stretchr/testify/assert"
 )
 
+type err1 struct {
+}
+
+func (e err1) Error() string {
+	return ""
+}
+
 func TestMap(t *testing.T) {
 	data := []int{1, 2, 3, 4}
 	t.Log(Map(data, func(i int) string {
 		return strconv.Itoa(data[i])
 	}))
 }
+
+func TestIsNil(t *testing.T) {
+	assert.Equal(t, IsNil(err1{}), false)
+	assert.Equal(t, IsNil(struct{}{}), false)
+	assert.Equal(t, IsNil(nil), true)
+	assert.Equal(t, IsNil(any(nil)), true)
+	assert.Equal(t, IsNil((*struct{})(nil)), true)
+}

stack/stack.go

@@ -9,7 +9,7 @@ import (
 )
 
 var (
-	cache  = make(map[uintptr]*Frame)
+	cache  sync.Map
 	mu     sync.Mutex
 	goRoot string
 )
@@ -110,22 +110,20 @@ func stack(p uintptr) *Frame {
 		return nil
 	}
 
-	v, ok := cache[p]
+	v, ok := cache.Load(p)
 	if ok {
-		return v
+		return v.(*Frame)
 	}
 
 	mu.Lock()
 	defer mu.Unlock()
 
-	v, ok = cache[p]
+	v, ok = cache.Load(p)
 	if ok {
-		return v
+		return v.(*Frame)
 	}
 
-	defer func() {
-		cache[p] = v
-	}()
+	defer func() { cache.Store(p, v) }()
 
 	ff := runtime.FuncForPC(p)
 	if ff == nil {
@@ -140,7 +138,7 @@ func stack(p uintptr) *Frame {
 		Name: ma[len(ma)-1],
 		Pkg:  strings.Join(ma[:len(ma)-1], "."),
 	}
-	return v
+	return v.(*Frame)
 }
 
 func pkgIndex(file, funcName string) int {