-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow closing parenthesis as valid trailing symbol #88
base: master
Are you sure you want to change the base?
Conversation
Where have you encountered this kind of company names? In what country, what name? Any other relevant info (e.g. what is typically inside the parenthesis)? |
As shown in the linked issue I often come across content where a country is added behind the company name in parentheses. You could argue the country should also be removed, but I'm not sure that would be in-scope for this package. Certainly it shouldn't be removing just the final closing parenthesis. |
Yes I understood you have encountered such real cases. Could you provide some actual real world examples? Do you know if the country specifier part inside parenthesis is actually part of the official legal name as registered in whatever national jurisdiction? Or has it been added by or in whatever system (to help differentiate company names)? People sometimes use this kind of patterns when entering data in CRMs etc. |
Oh, I see what you mean. Sure, below are some examples from a vendor's database. From what I can tell the data in parentheses is never part of the legal name, it's added e.g. for trade names, distinguishing subsidiaries, or differentiating to other companies with the same name in a different country.
|
Hello, any update on this? I came across the same problem, and it's not limited to country names in real-world datasets. Whether to retain Also: would you accept a separate PR which allows cleanco to handle removable elements in brackets like |
Fixes #61
Since we are looking at the tail, I decided to only allow
)
. I don't see how a valid name could end in(