-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document BaseCache expires value #251
Labels
Comments
Closed
As the date is typically provided by the server, we parse the timezone in order to try to make sure we're making the appropriate comparisons. I can imagine it could be better to convert to UTC, but I can also imagine there could be dragons there too. In any case, if you look at the code and find a better answer that could use more docs and/or a change in behavior to use UTC, it seems like a legit change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It would be helpful if the value for expires in
BaseCache.set
was documented. I couldn't find it and the redis/file caches aren't explicit.Is the expires value guaranteed to be in UTC?
Related #250
The text was updated successfully, but these errors were encountered: