Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure all isinstance checks account for undecided types #237

Open
pschanely opened this issue Jan 12, 2024 · 0 comments
Open

Ensure all isinstance checks account for undecided types #237

pschanely opened this issue Jan 12, 2024 · 0 comments

Comments

@pschanely
Copy link
Owner

Internal to CrossHair, all isinstance checks when guarded by NoTracing should invoke typeable_value beforehand.

#235 is one example of this kind of issue, but there are likely many more.

We should performa full review of these cases and make adjustments as necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pschanely