-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add exporter runtime metrics #9
add exporter runtime metrics #9
Comments
@wtip Are the logs enough or do we want it to be exposed as an actual metric? I have no real preference here. |
If you don't expose it as a prometheus metric you can't monitor the scrape duration with prometheus. |
@wtip actually, scrape duration are automatically exposed as metrics by prometheus itself ( Other "self" metrics could be relevant to monitor things like cpu usage, memory usage, threads, etc... the prometheus python_client should be able to provide all that. |
That's not required for |
@brian-brazil you're right! even better 💯 |
This exporter actually has multiple collectors running in parallel, it would be nice to have metrics to track how each one is behaving. node_exporter is doing that (see Also, the python_client metrics aren't available yet. |
Use the global REGISTRY, in order : 1) add exporter runtime metrics (fix pryorda#9 ) 2) add more metrics later (collection time for each object type) This patch is intended to expose internal metrics on `/metrics` only for the default section (so people with multiple sections `?section=something` don't get duplicate metrics).
Instead of the globabl registry, we could use an alternate endpoint for internal metrics. usualy
|
From @wtip on September 12, 2017 21:17
It would be nice to add some exporter runtime metrics.
For example at the moment it would be really useful if I knew how long the exporter is taking to scrape vmware for metrics.
Copied from original issue: rverchere/vmware_exporter#17
The text was updated successfully, but these errors were encountered: