Skip to content
This repository has been archived by the owner on Jan 15, 2022. It is now read-only.

smart_text() is deprecated in favor of smart_str() #64

Open
sde1000 opened this issue Jun 9, 2020 · 3 comments · May be fixed by #66
Open

smart_text() is deprecated in favor of smart_str() #64

sde1000 opened this issue Jun 9, 2020 · 3 comments · May be fixed by #66

Comments

@sde1000
Copy link

sde1000 commented Jun 9, 2020

Using django-bootstrap-breadcrumbs 0.9.2 with Django 3.0.7, I get the following deprecation warning:

lib/python3.8/site-packages/django_bootstrap_breadcrumbs/templatetags/django_bootstrap_breadcrumbs.py:151: RemovedInDjango40Warning: smart_text() is deprecated in favor of smart_str().
  links.append((url, smart_text(label) if label else label))

Checking the Django source it looks like smart_text() is now just a call to smart_str().
@sde1000
Copy link
Author

sde1000 commented Jun 9, 2020

(It looks like I mentioned this in #60 but only the first of the two warnings got fixed.)

@FlipperPA FlipperPA linked a pull request Feb 22, 2021 that will close this issue
Open
@richardbrockie
Copy link

Is this merge going to occur - it's been pending for almost 2 years...?

@christianwgd
Copy link

And now it breaks Dango 4.0 compatibility, since smart_text was removed. Would be great to see this merged and released.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIX: smart_text is deprecated; use smart_str. (Django deprecation) FlipperPA/bootstrap-breadcrumbs
3 participants
@sde1000 @christianwgd @richardbrockie