Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for composite keys #92

Open
andrewthad opened this issue Mar 3, 2015 · 6 comments
Open

Support for composite keys #92

andrewthad opened this issue Mar 3, 2015 · 6 comments

Comments

@andrewthad
Copy link

@meteficha Just wanted to make sure this didn't get forgotten. Here is a branch that sort of adds composite key support to Esqueleto: #88. Although I don't think that it met the original goal of letting you use composite keys as conditions, at least it lets you work with entities that have a composite key (the current behavior of esqueleto is still to look for a column named "id", which makes all queries fail). Greg has merged the prerequisite branch into persistent, so you could now merge this one in? Thanks.

@andrewthad
Copy link
Author

Bump.

1 similar comment
@andrewthad
Copy link
Author

Bump.

@theunixman
Copy link

I'm testing this in a project that uses custom keys now, too, if there's anything to investigate.

@andrewthad
Copy link
Author

I'm using this branch of esqueleto for now, and I can confirm that it does work.

@albertov
Copy link
Contributor

@andrewthad, just to clarify: It does let you use composite keys as conditions (see https://github.com/meteogrid/esqueleto/blob/12a2d2de2b05157d50b0edf2ffaf2af8e4bc6307/test/Test.hs#L598). What I haven't managed to implement yet (AFAICT) are all the tests marked with pendingWith

@andrewthad
Copy link
Author

Good to know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants