-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect duplicate transactions (maybe based on transaction ID) #44
Comments
Why not. If we want to implement it. We should add a function which is called after the readin and does checks like this and other (e.g. do the buy/sell positions match?) |
#127 matches identical operations together. It raises an error, when identical operations exist in two different files (duplicate!?). In the branch, identical transactions in the same file will be merged together without a warning. I don't think that this is a huge issue, because account statements should be gathered directly from the exchange and added to CoinTaxman without any custom changes. |
I haven't tried out whether saving account statements covering overlapping time ranges causes problems
However, the transaction ID of other exchanges doesn't appear to be used yet. Do you think it's beneficial to use it for detecting "duplicate" transactions?
The text was updated successfully, but these errors were encountered: