ValueError: Operation.change must be positive. - input Kraken Statement

[19lex82]

i get the Error: ValueError: Operation.change must be positive. i used kraken Statements

the column "fee" contains negative values like: -0.3195

does the statement had only positive values before or did i make a mistake?

[provinzio]

I do not use kraken myself. Are all your fees negative? Perhaps we need to fix the readin function in book.py

[19lex82]

yes if the is a fee, it is negativ

[Griffsano]

If the fee is negative, it seems like the export was changed by Kraken. Could you verify if your export looks like the actions in #97?

If any other fields changed as well, it may be possible to automatically detect the new export format. If everything stayed the same except for the sign of the fee, we could take the absolute value of the fee (if it is guaranteed that a fee is always deducted from the balance and not added).

[provinzio]

@19lex82 the PR should offer you a quick fix for your problem.

@Griffsano Instead of using the absolute value, I am checking the fee sign of the file and raise an error, if there are fees with different signs in the same file. As I am not using kraken, it's difficult for me to decide whether this is good to merge; for me it looks like it's ok. Should be good enough, what do you think?

[Griffsano]

@provinzio Yes, checking for a consistent sign within a file is even better, #163 looks good to me.
Let's wait for @19lex82 to confirm if anything else changed in the export format.

[19lex82]

i checked the column-headers by the csv download yesterday from kraken. yes looks like column-headers are the same

thanks