Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label of New York is blinking #256

Open
wipfli opened this issue Jun 10, 2024 · 6 comments
Open

Label of New York is blinking #256

wipfli opened this issue Jun 10, 2024 · 6 comments

Comments

@wipfli
Copy link
Collaborator

wipfli commented Jun 10, 2024

The label of New York City is blinking during zoom.

  • zoom 1 to 2: visible
  • zoom 2 to 3.65: hidden
  • zoom 3.65 to 4.65: visible
  • zoom 4.65 to 4.85: hidden
  • zoom 4.85 and more: visible
@wipfli
Copy link
Collaborator Author

wipfli commented Jun 10, 2024

Probably this is due to collisions between the places_locality layer and the places_region layer.

@bdon
Copy link
Member

bdon commented Jun 12, 2024

I noticed this is happening because we have NE localities conflicting with OSM ones.

We should take geometries only from OSM and augment them with NE properties / minzoom information.

@wipfli
Copy link
Collaborator Author

wipfli commented Jun 24, 2024

The Delhi city label also gets collided away by a state label:

map=8.77/28.5699/77.0001

image

@nvkelso
Copy link
Collaborator

nvkelso commented Jun 24, 2024

I wonder about styling all the labels in the places data layer in a single style layer, sorted my the pmap:min_zoom. Then the collisions would be deterministic (if a low-zoom locality is present and labeled before the region, it should win in a collision in later zooms with region, not just other locality features). This would require more complicated nested styling logic, but worth prototyping?

@wipfli
Copy link
Collaborator Author

wipfli commented Jun 24, 2024

Interesting idea I think. Another option could be to disable certain state and country labels (e g.: Delhi, Vatican).

@bdon
Copy link
Member

bdon commented Aug 22, 2024

Given the situation in #286 I think tile ordering isn't good enough, so we should do this in the style:

I wonder about styling all the labels in the places data layer in a single style layer, sorted my the pmap:min_zoom

bdon added a commit that referenced this issue Aug 23, 2024
* Places: don't use Natural Earth at low zooms [#256, #282]

* bump tiles version to 4.0.0-alpha.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants