-
Notifications
You must be signed in to change notification settings - Fork 15.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pacify address sanitizer on windows #20245
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@isanych - could you try reverting the changes to Also, you're correct, and my earlier PR feedback request to add version gating on MSVC is not needed. You can remove that entirely. |
@JasonLunn Removed extension_set.cc change and version guards. No sure how, but I don't see failures in this variant too - both grpc build and test which originated this investigation are ok. |
Fixes #20171