Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pacify address sanitizer on windows #20245

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

isanych
Copy link

@isanych isanych commented Feb 5, 2025

Fixes #20171

Copy link

google-cla bot commented Feb 5, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@isanych isanych changed the title Pacify address sanitizer on windows, Fixes #20171 Pacify address sanitizer on windows Feb 5, 2025
@google-cla google-cla bot added cla: yes and removed cla: no labels Feb 5, 2025
@JasonLunn JasonLunn added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Feb 5, 2025
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Feb 5, 2025
@JasonLunn JasonLunn added windows 🅰️ safe for tests Mark a commit as safe to run presubmits over labels Feb 5, 2025
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Feb 5, 2025
@JasonLunn JasonLunn added the c++ label Feb 5, 2025
@JasonLunn JasonLunn added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Feb 5, 2025
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Feb 5, 2025
@JasonLunn JasonLunn added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Feb 6, 2025
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Feb 6, 2025
@JasonLunn
Copy link
Contributor

@isanych - could you try reverting the changes to extension_set.cc and verify if the changes to the dynamic_message.cc alone are sufficient?

Also, you're correct, and my earlier PR feedback request to add version gating on MSVC is not needed. You can remove that entirely.

@isanych
Copy link
Author

isanych commented Feb 7, 2025

@isanych - could you try reverting the changes to extension_set.cc and verify if the changes to the dynamic_message.cc alone are sufficient?

Also, you're correct, and my earlier PR feedback request to add version gating on MSVC is not needed. You can remove that entirely.

@JasonLunn Removed extension_set.cc change and version guards. No sure how, but I don't see failures in this variant too - both grpc build and test which originated this investigation are ok.

@JasonLunn JasonLunn added 🅰️ safe for tests Mark a commit as safe to run presubmits over and removed wait for user action labels Feb 7, 2025
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Feb 7, 2025
@JasonLunn JasonLunn self-requested a review February 7, 2025 15:13
@JasonLunn JasonLunn added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Feb 7, 2025
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

protoc AddressSanitizer: new-delete-type-mismatch
2 participants