Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking Change: Dropping support for Bazel+MSVC #20085

Open
mkruskal-google opened this issue Jan 23, 2025 · 0 comments
Open

Breaking Change: Dropping support for Bazel+MSVC #20085

mkruskal-google opened this issue Jan 23, 2025 · 0 comments

Comments

@mkruskal-google
Copy link
Member

mkruskal-google commented Jan 23, 2025

This issue is a placeholder for gathering feedback on an upcoming breaking change

Due to persistent issues with MSVC's path length limits, we've decided to drop support for Bazel in 34.0. Starting in 30.0, you will need to explicitly set a flag --define=protobuf_allow_msvc=true to use this combination. Our recommended alternative is clang-cl, which we will officially support going forward.

If you're not using Protobuf-C++ and you've hit this issue purely because you need to build protoc from source, just use the opt-out flag for now. We will be releasing a prebuilt protoc toolchain by 34.0, which should decouple you from this.

copybara-service bot pushed a commit that referenced this issue Jan 23, 2025
An opt-out flag `--define=protobuf_allow_msvc=true` will be available until our 2026 breaking release 34.0. See #20085 for more details.

#test-continuous

PiperOrigin-RevId: 718525948
copybara-service bot pushed a commit that referenced this issue Jan 23, 2025
An opt-out flag `--define=protobuf_allow_msvc=true` will be available until our 2026 breaking release 34.0. See #20085 for more details.

#test-continuous

PiperOrigin-RevId: 718525948
copybara-service bot pushed a commit that referenced this issue Jan 23, 2025
An opt-out flag `--define=protobuf_allow_msvc=true` will be available until our 2026 breaking release 34.0. See #20085 for more details.

#test-continuous

PiperOrigin-RevId: 718525948
copybara-service bot pushed a commit that referenced this issue Jan 23, 2025
An opt-out flag `--define=protobuf_allow_msvc=true` will be available until our 2026 breaking release 34.0. See #20085 for more details.

#test-continuous

PiperOrigin-RevId: 718525948
copybara-service bot pushed a commit that referenced this issue Jan 23, 2025
An opt-out flag `--define=protobuf_allow_msvc=true` will be available until our 2026 breaking release 34.0. See #20085 for more details.

#test-continuous

PiperOrigin-RevId: 718525948
copybara-service bot pushed a commit that referenced this issue Jan 23, 2025
An opt-out flag `--define=protobuf_allow_msvc=true` will be available until our 2026 breaking release 34.0. See #20085 for more details.

#test-continuous

PiperOrigin-RevId: 718525948
copybara-service bot pushed a commit that referenced this issue Jan 28, 2025
An opt-out flag `--define=protobuf_allow_msvc=true` will be available until our 2026 breaking release 34.0. See #20085 for more details.

#test-continuous

PiperOrigin-RevId: 718525948
copybara-service bot pushed a commit that referenced this issue Jan 28, 2025
An opt-out flag `--define=protobuf_allow_msvc=true` will be available until our 2026 breaking release 34.0. See #20085 for more details.

#test-continuous

PiperOrigin-RevId: 718525948
copybara-service bot pushed a commit that referenced this issue Jan 28, 2025
An opt-out flag `--define=protobuf_allow_msvc=true` will be available until our 2026 breaking release 34.0. See #20085 for more details.

#test-continuous

PiperOrigin-RevId: 718525948
copybara-service bot pushed a commit that referenced this issue Jan 28, 2025
An opt-out flag `--define=protobuf_allow_msvc=true` will be available until our 2026 breaking release 34.0. See #20085 for more details.

#test-continuous

PiperOrigin-RevId: 718525948
copybara-service bot pushed a commit that referenced this issue Jan 28, 2025
An opt-out flag `--define=protobuf_allow_msvc=true` will be available until our 2026 breaking release 34.0. See #20085 for more details.

#test-continuous

PiperOrigin-RevId: 718525948
copybara-service bot pushed a commit that referenced this issue Jan 28, 2025
An opt-out flag `--define=protobuf_allow_msvc=true` will be available until our 2026 breaking release 34.0. See #20085 for more details.

#test-continuous

PiperOrigin-RevId: 718525948
copybara-service bot pushed a commit that referenced this issue Jan 28, 2025
An opt-out flag `--define=protobuf_allow_msvc=true` will be available until our 2026 breaking release 34.0. See #20085 for more details.

#test-continuous

PiperOrigin-RevId: 718525948
copybara-service bot pushed a commit that referenced this issue Jan 28, 2025
An opt-out flag `--define=protobuf_allow_msvc=true` will be available until our 2026 breaking release 34.0. See #20085 for more details.

#test-continuous

PiperOrigin-RevId: 718525948
copybara-service bot pushed a commit that referenced this issue Jan 28, 2025
An opt-out flag `--define=protobuf_allow_msvc=true` will be available until our 2026 breaking release 34.0. See #20085 for more details.

#test-continuous

PiperOrigin-RevId: 718525948
copybara-service bot pushed a commit that referenced this issue Jan 28, 2025
An opt-out flag `--define=protobuf_allow_msvc=true` will be available until our 2026 breaking release 34.0. See #20085 for more details.

#test-continuous

PiperOrigin-RevId: 718525948
copybara-service bot pushed a commit that referenced this issue Jan 28, 2025
An opt-out flag `--define=protobuf_allow_msvc=true` will be available until our 2026 breaking release 34.0. See #20085 for more details.

#test-continuous

PiperOrigin-RevId: 718525948
copybara-service bot pushed a commit that referenced this issue Jan 28, 2025
An opt-out flag `--define=protobuf_allow_msvc=true` will be available until our 2026 breaking release 34.0. See #20085 for more details.

#test-continuous

PiperOrigin-RevId: 718525948
copybara-service bot pushed a commit that referenced this issue Jan 29, 2025
An opt-out flag `--define=protobuf_allow_msvc=true` will be available until our 2026 breaking release 34.0. See #20085 for more details.

#test-continuous

PiperOrigin-RevId: 718525948
copybara-service bot pushed a commit that referenced this issue Jan 29, 2025
An opt-out flag `--define=protobuf_allow_msvc=true` will be available until our 2026 breaking release 34.0. See #20085 for more details.

#test-continuous

PiperOrigin-RevId: 718525948
copybara-service bot pushed a commit that referenced this issue Jan 29, 2025
An opt-out flag `--define=protobuf_allow_msvc=true` will be available until our 2026 breaking release 34.0. See #20085 for more details.

#test-continuous

PiperOrigin-RevId: 718525948
copybara-service bot pushed a commit that referenced this issue Jan 29, 2025
An opt-out flag `--define=protobuf_allow_msvc=true` will be available until our 2026 breaking release 34.0. See #20085 for more details.

#test-continuous

PiperOrigin-RevId: 718525948
copybara-service bot pushed a commit that referenced this issue Jan 29, 2025
An opt-out flag `--define=protobuf_allow_msvc=true` will be available until our 2026 breaking release 34.0. See #20085 for more details.

#test-continuous

PiperOrigin-RevId: 720822739
yukawa added a commit to yukawa/mozc that referenced this issue Feb 9, 2025
As seen in the following thread, the protobuf team is planning to stop
supporting the combination of Bazel and cl.exe due to well-known its
path length limitation.

 * protocolbuffers/protobuf#20085

As a preparation before switching to protobuf v30 (google#1177), let's
explicitly add a commandline option as explained to continue using this
combination as a short term solution.

This commit should have no impact on Probobuf v29.x.
hiroyuki-komatsu pushed a commit to google/mozc that referenced this issue Feb 12, 2025
As seen in the following thread, the protobuf team is planning to stop
supporting the combination of Bazel and cl.exe due to well-known its
path length limitation.

 * protocolbuffers/protobuf#20085

As a preparation before switching to protobuf v30 (#1177), let's
explicitly add a commandline option as explained to continue using this
combination as a short term solution.

This commit should have no impact on Probobuf v29.x.

PiperOrigin-RevId: 725882774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant