Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all usage of new Buffer(); use Buffer.from()/Buffer.alloc() #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove all usage of new Buffer(); use Buffer.from()/Buffer.alloc() #103

wants to merge 1 commit into from

Conversation

RyanZim
Copy link

@RyanZim RyanZim commented Jun 18, 2020

Fixes #99

@RyanZim RyanZim mentioned this pull request Jun 18, 2020
Merged
@RyanZim
Copy link
Author

RyanZim commented Jun 19, 2020

Worth noting that you'll have to bump Node version requirements; since Buffer.alloc was added in v5.10.0

@PavelPivkin PavelPivkin mentioned this pull request Oct 15, 2021
Open
@PavelPivkin
Copy link

Let's merge it to main branch? @RyanZim

@IPRIT
Copy link

IPRIT commented Nov 12, 2021

Ping

@IPRIT
Copy link

IPRIT commented Jan 24, 2022

Up

@dkildar
Copy link

dkildar commented Jul 17, 2024

The last merge was 6 years ago, it seems this repository is no longer supporting anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove usages of deprecated Buffer()
4 participants
@RyanZim @PavelPivkin @IPRIT @dkildar