Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message.decode ignores length argument #78

Open
IjzerenHein opened this issue Sep 10, 2016 · 1 comment
Open

Message.decode ignores length argument #78

IjzerenHein opened this issue Sep 10, 2016 · 1 comment

Comments

@IjzerenHein
Copy link

Hi,

First of all, I'd like to say, awesome library, kudos any many thanks for writing this 😃 😃 😃

I think I've come across a bug when decoding a message. According to the documentation I can pass in a length to the Message.decode function. However, the length is ignored and instead it tries to decode the whole buffer.

This is the code:

image

As you can see, the length argument is not used anywhere in this function, nor passed along to T.decode(). This seems like a bug to me. Or am I missing something here?

Cheers,
Hein

@IjzerenHein
Copy link
Author

IjzerenHein commented Sep 11, 2016

Oops, I accidentally put this bug report in the wrong repo, should have been the Protobuf repo. My bad, sorry. I just found out that it's a duplicate of protobufjs/protobuf.js#436 and it has actually been fixed on the master of protobuf, but not yet on the 5.0.1 npm version.
Are there any plans of updating protobuf on npm?
Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant