return in finally swallows exceptions

[iritkatriel]

In

partial-json-parser/src/partial_json_parser/core/complete.py

Line 32 in 265c965

return index

there is a return statement in a finally block, which would swallow any in-flight exception.

This means that if any exception is raised from the try body (including BaseException such as KeyboardInterrupt), it will not propagate on as expected.

See also https://docs.python.org/3/tutorial/errors.html#defining-clean-up-actions.

[CNSeniorious000]

Thanks. I considered it acceptable because I thought that try-block would only raise an IndexError at the end of the input string.

partial-json-parser/src/partial_json_parser/core/complete.py

Lines 26 to 33 in 265c965

	def skip_blank(text: str, index: int):
	try:
	while text[index].isspace():
	index += 1
	finally:
	return index

Did you find some other exceptions raised but shallowed inside that block?

[CNSeniorious000]

I see. You meant KeyboardInterrupt. I think other BaseException wouldn't raise inside that 🤔

Why do you want to interrupt that process? Are you trying to parse a long string with a lot of spaces?

[iritkatriel]

I'm not using this code. I am doing static analysis of many open source projects to understand usages of finally (and incidentally reporting problems when I see them).

[iritkatriel]

I considered it acceptable because I thought that try-block would only raise an IndexError at the end of the input string.

If your intention is to swallow all exceptions, I'd do that with explicitly with except BaseException: pass to make it clear that it's intentional. Your call.

[CNSeniorious000]

Thanks for reporting. And I'm a bit curious if you are working on a linting tool or if you are involved in some statistical research? I would love to learn about your findings.

[iritkatriel]

Thanks for reporting. And I'm a bit curious if you are working on a linting tool or if you are involved in some statistical research? I would love to learn about your findings.

https://github.com/iritkatriel/finally/blob/main/README.md

[CNSeniorious000]

thx!