Looks like circleci has a problem :(

can I get a review @gotjosh

Also I noticed the code is actually prepared to allow for users to pass custom functions to the templating.
https://github.com/prometheus/alertmanager/blob/main/template/template.go#L68C23-L70
https://github.com/prometheus/alertmanager/blob/main/template/template_test.go#L406-L468

But that is not accessible from what I have seen in code and docs.
If it is accessible it is a bigger issue if you consider users might use an alertmanager provided by someone else, since the user could execute harmful code. So I wonder if option for template.New and template.FromGlobs should be removed.

Also I noticed the code is actually prepared to allow for users to pass custom functions to the templating. https://github.com/prometheus/alertmanager/blob/main/template/template.go#L68C23-L70 https://github.com/prometheus/alertmanager/blob/main/template/template_test.go#L406-L468

But that is not accessible from what I have seen in code and docs. If it is accessible it is a bigger issue if you consider users might use an alertmanager provided by someone else, since the user could execute harmful code. So I wonder if option for template.New and template.FromGlobs should be removed.

This is all internal code. Users cannot add their own functions without changing and re-compiling the code.

@grobinson-grafana, @TheMeier, how can we speed up the review of this PR?

The functionality to be added, if this PR is accepted, will eliminate a large number of existing limitations. For example, time-related functions will allow for creating links to Grafana dashboards with a time range tied to the time the alert was triggered.

@grobinson-grafana, @TheMeier, how can we speed up the review of this PR?

The functionality to be added, if this PR is accepted, will eliminate a large number of existing limitations. For example, time-related functions will allow for creating links to Grafana dashboards with a time range tied to the time the alert was triggered.

The only ones who can help here are the maintainers. I guess they are busy with other stuff, so you just have to wait

The only ones who can help here are the maintainers. I guess they are busy with other stuff, so you just have to wait

Yep, I'll be hoping that they can find the time. This feature would indeed be very useful.

While we figure out whether or not to accept sprig, I've opened a PR that adds much requested date and timezone functions here.