Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Move to Alertmanager. #145

Open
bwplotka opened this issue Dec 22, 2022 · 11 comments
Open

Proposal: Move to Alertmanager. #145

bwplotka opened this issue Dec 22, 2022 · 11 comments

Comments

@bwplotka
Copy link
Member

Given the popularity and use, I would like to propose pushing this code to Alertmanager notify package.

I got information AM maintainers will consider this (:

We need, however, maintainer for this notifier. Any volunteers? (:

@bwplotka
Copy link
Member Author

We also need official maintainer. I can co-maintain, but we need someone else to own this, so looking for volunteers (:

@bwplotka bwplotka reopened this Feb 17, 2023
@twotired
Copy link
Contributor

@bwplotka What's involved with being the maintainer? I'm open to being co-maintainer at least.

@bwplotka
Copy link
Member Author

Just a general review of related PRs, issues and security fixes (:

Thanks, noted! Are you on the cncf slack?

@twotired
Copy link
Contributor

I am there, in the #jiralert channel

@raonisiann
Copy link

I can help as maintainer as well if you still needed. I joined on slack channel #jiraalert

@holger-waschke
Copy link
Contributor

I can help as maintainer aswell if help is needed. We use jiralert in a large environment.

@bwplotka
Copy link
Member Author

bwplotka commented Jun 9, 2023

Amazing thanks! I think we have nice collection of contributors to attempt the move. Any of you would have time to prepare a PR to Alertmanager? I can even create feature branch for us. We can then together work towards PR with jiralert plugin in https://github.com/prometheus/alertmanager as well as documentation (: I will be there to consult and review (together with Alertmanager maintainers e.g. @simonpasquier)

@twotired
Copy link
Contributor

I was a little confused by what's needed here. I thought there was a need for additional maintainers of this project so that there could be a greater capacity to review and approve PRs and create new releases. Is that not in consideration?

I would be open to helping with the migration, but right now the priority for my team is to get some of the fixes in PRs into a new release. It is especially painful when we keep hitting the 32KB limit and JIRAs cannot be updated.

@bwplotka
Copy link
Member Author

Sorry for confusion, but as description suggests (#145 (comment)) this issue is about proposing it to Alertmanager and maintaining similar code (with the same functionality) there (:

but right now the priority for my team is to get some of the fixes in PRs into a new release. It is especially painful when we keep hitting the 32KB limit and JIRAs cannot be updated.

Yup, feel free to propose changes to this repo for now. Whatever we do here will be useful in Alertmanager 👍🏽

@jkroepke
Copy link
Member

jkroepke commented Nov 12, 2023

I've setup an PR on alertmanager

@jkroepke
Copy link
Member

jkroepke commented Aug 8, 2024

The PR is merged on AM site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants