-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fluent-react bindings should set the directionality of the page (rtl, ltr) #522
Comments
I noticed that the I noticed that the devtools folks set the But I noticed that other pages using Fluent work properly (both for |
I am under the impression that fluent-dom doesn't do it either. In Firefox there is a adhoc mechanism to do it automatically, but that it's not implemented in the generic library. |
Currently when applying locales, the fluent-react bindings do not switch the document's text directionality. It's a little odd for React to affect the entire document, but here it seems like it would be the better and less surprising behavior.
I recently converted Firefox's
about:profiling
page to use Fluent React. However, a follow-up Bug 1688195 was filed as RTL support was not working. I was somewhat surprised that this was the case, as I would have assumed fluent-react to handle this for me.One way to mitigate surprise for the end user would be to set the RTL direction, by default, and have a config option to opt out of the behavior.
The text was updated successfully, but these errors were encountered: