Skip to content

Commit 30067da

Browse files
authored
return error earlier when no nodes available (#617)
1 parent f834c87 commit 30067da

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

cluster/calcium/create.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,9 @@ func (c *Calcium) doCreateWorkloads(ctx context.Context, opts *types.DeployOptio
103103
}
104104
}()
105105
return c.withNodesPodLocked(ctx, opts.NodeFilter, func(ctx context.Context, nodeMap map[string]*types.Node) (err error) {
106+
if len(nodeMap) == 0 {
107+
return types.ErrEmptyNodeMap
108+
}
106109
nodenames := []string{}
107110
nodes := []*types.Node{}
108111
for nodename, node := range nodeMap {

types/errors.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ var (
8181
ErrInvalidGitURL = errors.New("invalid git url format")
8282
ErrInvalidVolumeBind = errors.New("invalid volume bind value")
8383
ErrEmptyNodeName = errors.New("node name is empty")
84+
ErrEmptyNodeMap = errors.New("node map is empty")
8485
ErrEmptyAppName = errors.New("app name is empty")
8586
ErrEmptyPodName = errors.New("pod name is empty")
8687
ErrEmptyImage = errors.New("image is empty")

0 commit comments

Comments
 (0)