Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize CEL validation in Contour CRDs #6122

Open
5 tasks
sunjayBhatia opened this issue Jan 24, 2024 · 1 comment
Open
5 tasks

Utilize CEL validation in Contour CRDs #6122

sunjayBhatia opened this issue Jan 24, 2024 · 1 comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@sunjayBhatia
Copy link
Member

Our CRD field validation is a bit inconsistent and could use a refresh. We don't have consistent validation for similar fields and should probably introduce dedicated common types for some. For example, namespace name validation:

Also, much of our HTTPProxy|ExtensionService|etc. Processor logic is dedicated to validating CRD fields and setting Invalid status on resources that have bad config. If we can use CEL validations to do some of this work at resource creation time we may be able to prevent This would enable us to immediately surface configuration errors rather than requiring users to create a resource, check status, etc.

  • HTTPProxy
  • TLSCertificateDelegation
  • ContourConfiguration
  • ContourDeployment
  • ExtensionService
@sunjayBhatia sunjayBhatia added kind/feature Categorizes issue or PR as related to a new feature. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Jan 24, 2024
@flawedmatrix flawedmatrix self-assigned this Feb 16, 2024
@flawedmatrix
Copy link
Contributor

Assigning to myself since I've been looking at this today.

@flawedmatrix flawedmatrix removed the lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. label Feb 16, 2024
@flawedmatrix flawedmatrix removed their assignment Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants